Rework alias linking to ensure links are only created within bin directory#277
Open
zooba wants to merge 5 commits intopython:mainfrom
Open
Rework alias linking to ensure links are only created within bin directory#277zooba wants to merge 5 commits intopython:mainfrom
zooba wants to merge 5 commits intopython:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes broken executables in the Python bin directory by reworking the alias linking mechanism to ensure hard links are only created within the bin directory itself, rather than linking to files in the Python installation directory.
Changes:
- Modified alias creation logic to search for existing launchers within the bin directory for hard linking instead of linking directly to installation directory files
- Added support for the
forceflag to unconditionally recreate aliases - Updated test expectations to reflect new debug log messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/manage/aliasutils.py | Refactored _create_alias function to search for existing launchers in the bin directory and link to those instead of linking to installation files, avoiding cross-directory linking issues |
| tests/test_alias.py | Added force = False attribute to test Cmd class and updated test assertions to match new logging behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258